From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65326-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18224 invoked by alias); 10 Jul 2009 09:34:08 -0000
Received: (qmail 18214 invoked by uid 22791); 10 Jul 2009 09:34:07 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jul 2009 09:34:00 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n6A9XgfE018060; 	Fri, 10 Jul 2009 11:33:43 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n6A9Xfxk000967; 	Fri, 10 Jul 2009 11:33:41 +0200 (CEST)
Date: Fri, 10 Jul 2009 14:34:00 -0000
Message-Id: <200907100933.n6A9Xfxk000967@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: dje@google.com
CC: teawater@gmail.com, gdb-patches@sourceware.org
In-reply-to: <e394668d0907091500l139a21dfg1ef6651c7b1e260e@mail.gmail.com> 	(message from Doug Evans on Thu, 9 Jul 2009 15:00:32 -0700)
Subject: Re: Add a new modifier /c to "disassemble" command to make it output  	binary code
References: <daef60380907082335j78b9ae35jaf552124a65022a3@mail.gmail.com> <e394668d0907091500l139a21dfg1ef6651c7b1e260e@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00305.txt.bz2

> Date: Thu, 9 Jul 2009 15:00:32 -0700
> From: Doug Evans <dje@google.com>
> 
> On Wed, Jul 8, 2009 at 11:35 PM, Hui Zhu<teawater@gmail.com> wrote:
> > Hi,
> >
> > The objdump will output the binary code when it works but gdb not.
> > I make a patch to add a new modifier /c to "disassemble" command to
> > make it output binary code.
> > Please help me review it.
> 
> I like the idea.
> The option to objdump is --[no-]show-raw-insn.
> The word "raw" is the mnemonic I use to remember the option name.
> Hence I wonder if it would be easier for users to remember
> "disassemble /r" than "disassemble /c".
> [nit picky, I know]

Actually I think you have a point here.  The term "code" is horribly
overloaded, so I felt a bit uncomfortable with the fact that the newly
added argument to print_disassembly carried that name:

>>  static void
>>  print_disassembly (struct gdbarch *gdbarch, const char *name,
>> -		   CORE_ADDR low, CORE_ADDR high, int mixed)
>> +		   CORE_ADDR low, CORE_ADDR high, int mixed, int code)

If people agree with Doug and me that /r is better than /c, can the
code be changed to match this?