From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28431 invoked by alias); 8 Jul 2009 20:46:50 -0000 Received: (qmail 28421 invoked by uid 22791); 8 Jul 2009 20:46:49 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Jul 2009 20:46:39 +0000 Received: (qmail 25716 invoked from network); 8 Jul 2009 20:46:37 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Jul 2009 20:46:37 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Use data cache for stack accesses Date: Wed, 08 Jul 2009 20:51:00 -0000 User-Agent: KMail/1.9.10 Cc: Jacob Potter References: <7e6c8d660907081308r13bff580rdcf4822c77df8403@mail.gmail.com> In-Reply-To: <7e6c8d660907081308r13bff580rdcf4822c77df8403@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200907082146.40513.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00272.txt.bz2 On Wednesday 08 July 2009 21:08:00, Jacob Potter write: > --- a/gdb/thread.c > +++ b/gdb/thread.c > @@ -848,6 +848,9 @@ switch_to_thread (ptid_t ptid) > =A0 =A0if (ptid_equal (ptid, inferior_ptid)) > =A0 =A0 =A0return; > =A0 > + =A0if (ptid_get_pid (ptid) !=3D ptid_get_pid (inferior_ptid)) > + =A0 =A0dcache_invalidate (target_dcache); > + I'm not sure this would be 100% multi-address space safe. Do we not have places where we switch inferior_ptid temporarily before calling reading memory, with save_inferior_ptid, without going through the high level switch_to_thread ? What if we do this within dcache itself, similarly to get_thread_regcache? That would be probably in memory_xfer_partial. --=20 Pedro Alves