Re: [patch] Fix i386 memory-by-register access on amd64

Tom Tromey
2009-06-25T16:33:55Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Resurrecting an oldish thread.

Jan> While not trying to judge what is right or wrong:

Jan> I believe gdb.x86_64 debugging gdb.i386 inferior should behave exactly as
Jan> gdb.i386 debugging gdb.i386 inferior.

This sounds reasonable to me. If I'm debugging a 32-bit inferior, it
seems weird to see a 64-bit address.

Jan> As value_as_address is a long function with many `return'
Jan> commands. But I do not have any strong opinion on it - would you
Jan> like to fill a variable and using a single exit path which would
Jan> cut the result width?

This sounds ok to me. value_as_address is really long, true, but it
is mostly comments. There are really only 3 returns.

Tom