From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3595 invoked by alias); 5 Jul 2009 21:36:09 -0000 Received: (qmail 3587 invoked by uid 22791); 5 Jul 2009 21:36:08 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Jul 2009 21:36:00 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.14.3/8.13.8) with ESMTP id n65LZli5567840 for ; Sun, 5 Jul 2009 21:35:47 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n65LZlWM1335480 for ; Sun, 5 Jul 2009 23:35:47 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n65LZkEm002068 for ; Sun, 5 Jul 2009 23:35:47 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n65LZjeg002063; Sun, 5 Jul 2009 23:35:45 +0200 Message-Id: <200907052135.n65LZjeg002063@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sun, 05 Jul 2009 23:35:45 +0200 Subject: Re: [RFA] Check solib bfd arch To: teawater@gmail.com (Hui Zhu) Date: Sun, 05 Jul 2009 21:36:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (gdb-patches ml), msnyder@vmware.com (Michael Snyder) In-Reply-To: from "Hui Zhu" at Jul 03, 2009 05:52:30 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00120.txt.bz2 Hui Zhu wrote: > + /* Check bfd arch. */ > + if (bfd_get_arch (abfd) != gdbarch_bfd_arch_info (target_gdbarch)->arch) This test seems to strict; there are cases where code of a different architecture *can* actually run on the current architecture (e.g. bfd_arch_rs6000 vs. bfd_arch_powerpc). The correct check would be something alone the lines of osabi.c:can_run_code_for. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com