From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30549 invoked by alias); 3 Jul 2009 19:43:12 -0000 Received: (qmail 30535 invoked by uid 22791); 3 Jul 2009 19:43:12 -0000 X-Spam-Check-By: sourceware.org Received: from pool-98-110-183-121.bstnma.fios.verizon.net (HELO cgf.cx) (98.110.183.121) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Jul 2009 19:42:30 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id F2B3C3B0008 for ; Fri, 3 Jul 2009 15:42:20 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id E9CD461F202; Fri, 3 Jul 2009 15:42:20 -0400 (EDT) Date: Fri, 03 Jul 2009 19:43:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: [RFC-v3] Add windows Thread Information Block Message-ID: <20090703194220.GA30668@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <000901c9f5ef$4ee06f10$eca14d30$@u-strasbg.fr> <20090626155254.GA15627@caradoc.them.org> <001f01c9fa5a$0e1297f0$2a37c7d0$@u-strasbg.fr> <831vp047u8.fsf@gnu.org> <20090701180419.GA8152@ednor.casa.cgf.cx> <003a01c9fbf8$f3e91610$dbbb4230$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003a01c9fbf8$f3e91610$dbbb4230$@u-strasbg.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00097.txt.bz2 On Fri, Jul 03, 2009 at 06:11:41PM +0200, Pierre Muller wrote: > > Here is a new version of this patch: > > - It does add a convenience variable name "$_tlb" >for "thread local base" as this is the only value that needs >to be fetch especially. > Maybe "_tib" is better, in the sense that it "talks" more to >windows used debuggers? But this is really only a pointer and not the >block itself. Any better idea? > > I tried to create a type that really fits >the Windows OS layout, but as this structure is not documented really >and has changed between OS version, there can be no >assurance that all fields are OK in all versions... > It works both native and remotely. > > I didn't check if it works OK, if endianess are different >but the extra field in extract_unsigned_integer should take care >of this. > > As Christopher reported problems trying to apply my previous >version, I attach it this time, hoping that this will avoid troubles. > > Pedro, I didn't change the TARGET_OBJECT type, >and I really want to know if this is really required, >as it seems to be a lot of work and I can't see the benefit... Approved (for the parts that I can approve). cgf