From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16368 invoked by alias); 2 Jul 2009 08:39:20 -0000 Received: (qmail 16358 invoked by uid 22791); 2 Jul 2009 08:39:19 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_32,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jul 2009 08:39:11 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n628b9Ra010096; Thu, 2 Jul 2009 04:37:09 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n628b8sl019383; Thu, 2 Jul 2009 04:37:08 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n628b6pj020458; Thu, 2 Jul 2009 04:37:07 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n628b6TT015126; Thu, 2 Jul 2009 10:37:06 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n628b5a2015123; Thu, 2 Jul 2009 10:37:05 +0200 Date: Thu, 02 Jul 2009 08:39:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org, Vladimir Prus Subject: Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs] Message-ID: <20090702083705.GA14783@host0.dyn.jankratochvil.net> References: <20090525080233.GD13323@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00058.txt.bz2 On Tue, 09 Jun 2009 22:50:42 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> I find the callback based iterator easier to use, [...] > It seems reasonable to me, though it would be nice to have Volodya's > approval. Is it OK to check it in, Vladimir? The patch would go in unchanged: http://sourceware.org/ml/gdb-patches/2009-05/msg00547.html Regression re-tested now on {x86_64,i686}-fedora-linux-gnu. > Jan> in fact there were bugs due to the > Jan> current calling semantics (`floating' lockup, memory leaks). > > Details on the bugs that this fixes would be nice. > A test case would also be nice, assuming these are testable. The `floating' lockup will get fixed by a later patch using this new all_root_varobjs function. A testcase for it was in a now-obsolete patch: [patch] Fix gdb.mi hang on floating VAROBJs http://sourceware.org/ml/gdb-patches/2009-05/msg00433.html This patch itself still does not fix it. The (small) memory caused by the current semantics you fixed by: RFA: fix PR 9350 http://sourceware.org/ml/gdb-patches/2009-01/threads.html#00066 7002b113b9e2afed981d3eb9d4157c98a3a3c447 http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/varobj.c.diff?cvsroot=src&r1=1.121&r2=1.122 Thanks, Jan