From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17298 invoked by alias); 30 Jun 2009 19:51:33 -0000 Received: (qmail 17285 invoked by uid 22791); 30 Jun 2009 19:51:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33 X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Jun 2009 19:51:30 +0000 Received: from sunsite.mff.cuni.cz (localhost [127.0.0.1]) by sunsite.mff.cuni.cz (8.14.3/8.14.3) with ESMTP id n5UJp1Kj031099; Tue, 30 Jun 2009 21:51:01 +0200 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.14.3/8.14.3/Submit) id n5UJp00A031098; Tue, 30 Jun 2009 21:51:00 +0200 Date: Tue, 30 Jun 2009 19:51:00 -0000 From: Jakub Jelinek To: Tom Tromey Cc: Ian Lance Taylor , gcc-patches@gcc.gnu.org, Binutils Development , gdb-patches@sourceware.org Subject: Re: Patch: merge src and gcc copies of dwarf2.h Message-ID: <20090630195100.GT3101@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00889.txt.bz2 On Mon, Jun 29, 2009 at 05:59:18PM -0600, Tom Tromey wrote: > >>>>> "Ian" == Ian Lance Taylor writes: > > >> + tem = ((unsigned int) loc->dw_loc_opc << 1) | loc->dtprel; > >> + CHECKSUM (tem); > > Ian> This appears to change the checksum, which probably doesn't matter too > Ian> much, but since it can appear in a .o file it seems to me that we might > Ian> as well keep the same checksum, as in > Ian> tem = (loc->dtprel << 8) | ((unsigned int) loc->dw_loc_opc); > > Oops, I did not realize this could end up in the .o. > > Ian> This patch is OK for gcc with that change. > > Thanks. I made this change and will check it in soon. > I'll post the corresponding src patch sometime soon. BTW, why is it , rather than just ? What is ELF specific on DWARF2/3/4? By putting dwarf2.h right into include/ rather than include/elf/, we could avoid issues with combined src+gcc trees. Jakub