From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21514 invoked by alias); 30 Jun 2009 18:08:11 -0000 Received: (qmail 21499 invoked by uid 22791); 30 Jun 2009 18:08:11 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Jun 2009 18:08:04 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5UI82jM028057 for ; Tue, 30 Jun 2009 14:08:02 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5UI7vT1010208 for ; Tue, 30 Jun 2009 14:08:01 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5UI7t4U004685 for ; Tue, 30 Jun 2009 14:07:56 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n5UI7s4m028799 for ; Tue, 30 Jun 2009 20:07:54 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n5UI7rNh028798 for gdb-patches@sourceware.org; Tue, 30 Jun 2009 20:07:53 +0200 Date: Tue, 30 Jun 2009 18:08:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] testsuite: gdb.base/setshow.exp fix racy FAILs Message-ID: <20090630180753.GA28670@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00881.txt.bz2 Hi, one cannot expect a string which is a substring of another expected string. Thanks, Jan gdb/testsuite/ 2009-06-30 Jan Kratochvil Remove racy FAILs relying just on the timeouts. * gdb.base/setshow.exp (set annotate 2, show annotate (2)) (annotation_level 2): Remove racy FAILs. --- a/gdb/testsuite/gdb.base/setshow.exp +++ b/gdb/testsuite/gdb.base/setshow.exp @@ -60,7 +60,6 @@ send_gdb "set annotate 2\n" gdb_expect { -re ".*\032\032pre-prompt.*$gdb_prompt .*\032\032prompt.*$" \ { pass "set annotate 2" } - -re ".*$gdb_prompt $" { fail "set annotate 2" } timeout { fail "(timeout) set annotate 2" } } @@ -68,7 +67,6 @@ send_gdb "show annotate\n" gdb_expect { -re ".*\032\032post-prompt.*Annotation_level is 2..*\032\032pre-prompt.*$gdb_prompt .*\032\032prompt.*$" \ { pass "show annotate (2)" } - -re ".*$gdb_prompt $" { fail "show annotate (2)" } timeout { fail "(timeout) show annotate (2)" } } @@ -77,7 +75,6 @@ send_gdb "info line 1\n" gdb_expect { -re ".*\032\032post-prompt.*Line 1 of .* is at address .* but contains no code.*:1:0:beg:0x.*\032\032pre-prompt.*$gdb_prompt .*\032\032prompt.*$" \ { pass "annotation_level 2" } - -re ".*$gdb_prompt $" { fail "annotation_level 2" } timeout { fail "(timeout) annotation_level 2" } }