From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [patch] Enable parallel make check also from gdb/
Date: Tue, 30 Jun 2009 17:37:00 -0000 [thread overview]
Message-ID: <20090630173718.GA24648@host0.dyn.jankratochvil.net> (raw)
Hi,
fix for:
RFC: parallelize "make check", Tom Tromey
http://sourceware.org/ml/gdb-patches/2009-06/threads.html#00660
which works from gdb/testsuite/ but not from gdb/ for running:
make check//unix/-m32
etc.
TARGET_FLAGS_TO_PASS the patch modifies only for `make check',
not for `make check//unix...'.
Thanks,
Jan
gdb/
2009-06-30 Jan Kratochvil <jan.kratochvil@redhat.com>
* Makefile.in (TARGET_FLAGS_TO_PASS): Include also FORCE_PARALLEL.
(check//%): Construct FORCE_PARALLEL for the sub-make. Extend the
comment for it.
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -620,7 +620,8 @@ TARGET_FLAGS_TO_PASS = \
"MAKEINFO=$(MAKEINFO)" \
"MAKEHTML=$(MAKEHTML)" \
"RUNTEST=$(RUNTEST)" \
- "RUNTESTFLAGS=$(RUNTESTFLAGS)"
+ "RUNTESTFLAGS=$(RUNTESTFLAGS)" \
+ "FORCE_PARALLEL=$(FORCE_PARALLEL)"
# All source files that go into linking GDB.
# Links made at configuration time should not be specified here, since
@@ -885,7 +886,8 @@ check: force
# will run 3 concurrent sessions of check, eventually testing all 10
# combinations. GNU make is required for the % pattern to work, as is
# a shell that expands alternations within braces. If GNU make is not
-# used, this rule will harmlessly fail to match.
+# used, this rule will harmlessly fail to match. Used FORCE_PARALLEL to
+# prevent serialized checking due to the passed RUNTESTFLAGS.
check//%: force
@if [ -f testsuite/config.status ]; then \
rootme=`pwd`; export rootme; \
@@ -905,6 +907,7 @@ check//%: force
else :; fi && cd $$testdir && \
$(MAKE) $(TARGET_FLAGS_TO_PASS) \
RUNTESTFLAGS="--target_board=$$variant $(RUNTESTFLAGS)" \
+ FORCE_PARALLEL=$(if $(FORCE_PARALLEL),1,$(if $(RUNTESTFLAGS),,1)) \
"$$target"; \
else true; fi
next reply other threads:[~2009-06-30 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 17:37 Jan Kratochvil [this message]
2009-06-30 20:20 ` Tom Tromey
2009-06-30 21:34 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630173718.GA24648@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox