From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29674 invoked by alias); 29 Jun 2009 17:29:45 -0000 Received: (qmail 29665 invoked by uid 22791); 29 Jun 2009 17:29:44 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Jun 2009 17:29:39 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.14.3/8.13.8) with ESMTP id n5THTbGS122546 for ; Mon, 29 Jun 2009 17:29:37 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5THTagp3727564 for ; Mon, 29 Jun 2009 19:29:36 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5THTao4006387 for ; Mon, 29 Jun 2009 19:29:36 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n5THTZJO006375; Mon, 29 Jun 2009 19:29:35 +0200 Message-Id: <200906291729.n5THTZJO006375@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 29 Jun 2009 19:29:35 +0200 Subject: Re: [rfa/Ada] Restructure fixed array range fall-back to remove builtin types To: brobecker@adacore.com (Joel Brobecker) Date: Mon, 29 Jun 2009 17:29:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20090629153842.GB7584@adacore.com> from "Joel Brobecker" at Jun 29, 2009 08:38:42 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00829.txt.bz2 Joel Brobecker wrote: > > * ada-lang.c (to_fixed_range_type): Add ORIG_TYPE argument. > > Fall back to orig_type as index type if symbol lookup fails. > > Allocate result types from ORIG_TYPE's objfile. > > (ada_array_bound_from_type, to_fixed_array_type, > > ada_evaluate_subexp): Pass original index type to > > to_fixed_range_type. Do not pass objfile. > > > > * ada-typeprint.c (print_range_type_named): Add ORIG_TYPE argument. > > Fall back to orig_type as index type if symbol lookup fails. > > (print_array_type, ada_print_type): Pass original index type > > to print_range_type_named. > > This makes sense to me, and I verified that you handle the case of > array index types that are range types. So OK. Checked in. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com