From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19148 invoked by alias); 29 Jun 2009 13:25:42 -0000 Received: (qmail 19135 invoked by uid 22791); 29 Jun 2009 13:25:41 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Jun 2009 13:25:30 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.14.3/8.13.8) with ESMTP id n5TDPRQ0124144 for ; Mon, 29 Jun 2009 13:25:27 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5TDPRLG3481820 for ; Mon, 29 Jun 2009 15:25:27 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5TDPRc0004851 for ; Mon, 29 Jun 2009 15:25:27 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n5TDPPbX004841; Mon, 29 Jun 2009 15:25:25 +0200 Message-Id: <200906291325.n5TDPPbX004841@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 29 Jun 2009 15:25:25 +0200 Subject: Re: [patch] [3/5] Types reference counting [make_function_type-objfile] To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Mon, 29 Jun 2009 13:25:00 -0000 From: "Ulrich Weigand" Cc: tromey@redhat.com (Tom Tromey), gdb-patches@sourceware.org In-Reply-To: <20090626163927.GA14063@host0.dyn.jankratochvil.net> from "Jan Kratochvil" at Jun 26, 2009 06:39:27 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00808.txt.bz2 > On Fri, 26 Jun 2009 15:23:00 +0200, Ulrich Weigand wrote: > > - I think the symbol readers should always return per-objfile types. This > > just makes everything simpler, in particular allocation of derived types > > (as you notice). I think it would also good to be able to guarantee that > > TYPE_OBJFILE of every symbol type is non-NULL ... > > > - The Java generated types should *not* go onto the "fake" dynamics objfile > > in the first place. That objfile is somewhat bogus in that it isn't > > associated with an architecture (thus breaking my per-type architecture > > effort), and it also don't help with type lifetime issues as the fake > > objfile never goes away. I think those types should be allocated with > > a NULL objfile (in the future are per-gdbarch types) instead. > > > Therefore, I'd prefer to fix the two problems mentioned above, and then > > revert your patch. > > If the current rule: > # So far always type A referencing -> type B had either the same TYPE_OBJFILE > # or TYPE_OBJFILE(B) was NULL. > > will be changed to: > # Type A referencing -> type B had the same TYPE_OBJFILE. > > I only welcome it and sure I agree with reverting my patch afterwards. I've now checked the two patches in. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com