From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31361 invoked by alias); 27 Jun 2009 19:48:59 -0000 Received: (qmail 31335 invoked by uid 22791); 27 Jun 2009 19:48:57 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 27 Jun 2009 19:48:45 +0000 Received: (qmail 20995 invoked from network); 27 Jun 2009 19:48:42 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jun 2009 19:48:42 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Patch to fix reverse return from subroutine error Date: Sat, 27 Jun 2009 19:48:00 -0000 User-Agent: KMail/1.9.10 Cc: Michael Snyder , Hui Zhu , Marc Khouzam References: <4A466BAE.2010305@vmware.com> In-Reply-To: <4A466BAE.2010305@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906272049.36692.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00770.txt.bz2 > - || execution_direction == EXEC_REVERSE)) > + || (execution_direction == EXEC_REVERSE > + && ecs->event_thread->step_frame_id.stack_addr_p > + && get_frame_id (get_current_frame ()).stack_addr_p > + && !gdbarch_inner_than (current_gdbarch, > + ecs->event_thread->step_frame_id.stack_addr, > + get_frame_id Sorry to pitch in so late, but this doesn't look right to me. Common code shouldn't be accessing frame id members directly, frame ids are supposed to be opaque. What is this trying to do? -- Pedro Alves