From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Michael Snyder <msnyder@vmware.com>,
Hui Zhu <teawater@gmail.com>,
Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: [RFA] Patch to fix reverse return from subroutine error
Date: Sat, 27 Jun 2009 19:56:00 -0000 [thread overview]
Message-ID: <20090627195552.GA7049@caradoc.them.org> (raw)
In-Reply-To: <200906272049.36692.pedro@codesourcery.com>
On Sat, Jun 27, 2009 at 08:49:35PM +0100, Pedro Alves wrote:
> > - || execution_direction == EXEC_REVERSE))
> > + || (execution_direction == EXEC_REVERSE
> > + && ecs->event_thread->step_frame_id.stack_addr_p
> > + && get_frame_id (get_current_frame ()).stack_addr_p
> > + && !gdbarch_inner_than (current_gdbarch,
> > + ecs->event_thread->step_frame_id.stack_addr,
> > + get_frame_id
>
> Sorry to pitch in so late, but this doesn't look right to me.
> Common code shouldn't be accessing frame id members directly, frame ids
> are supposed to be opaque. What is this trying to do?
Nor should it be using gdbarch_inner_than this way; Ulrich just got
through removing most of those. Stack frames do not necessarily need
to be inner than the previous frame.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-06-27 19:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 8:27 Hui Zhu
2009-06-27 18:59 ` Michael Snyder
2009-06-27 19:48 ` Pedro Alves
2009-06-27 19:56 ` Daniel Jacobowitz [this message]
2009-06-27 20:59 ` Michael Snyder
2009-06-27 21:12 ` Daniel Jacobowitz
2009-06-28 18:46 ` Michael Snyder
2009-06-28 21:09 ` Daniel Jacobowitz
2009-06-29 0:38 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090627195552.GA7049@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=msnyder@vmware.com \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox