From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9607 invoked by alias); 27 Jun 2009 18:01:34 -0000 Received: (qmail 9324 invoked by uid 22791); 27 Jun 2009 18:01:33 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 27 Jun 2009 18:01:27 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 9679310631; Sat, 27 Jun 2009 18:01:24 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 24728104B5; Sat, 27 Jun 2009 18:01:24 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MKcDK-0002Ai-UZ; Sat, 27 Jun 2009 14:01:22 -0400 Date: Sat, 27 Jun 2009 18:01:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: Mark Kettenis , tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [FYI] Inlining support, rough patch Message-ID: <20090627180122.GA6139@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , Mark Kettenis , tromey@redhat.com, gdb-patches@sourceware.org References: <20080613152754.GA4220@caradoc.them.org> <20080715192020.GB3094@caradoc.them.org> <200807172353.m6HNr1nY015884@brahms.sibelius.xs4all.nl> <20080718130308.GA19045@caradoc.them.org> <200807251446.m6PEkfwc027635@brahms.sibelius.xs4all.nl> <20080725174636.GB2433@caradoc.them.org> <200903312042.n2VKgIUx003764@brahms.sibelius.xs4all.nl> <20090420154909.GA5386@caradoc.them.org> <20090420155405.GA6072@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090420155405.GA6072@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00764.txt.bz2 On Mon, Apr 20, 2009 at 05:54:05PM +0200, Jan Kratochvil wrote: > On Mon, 20 Apr 2009 17:49:09 +0200, Daniel Jacobowitz wrote: > > Nothing algorithmic has changed, > > but we have a few bug fixes and improved testcases. > > Fedora also has various fixes on top of it: > http://cvs.fedora.redhat.com/viewvc/rpms/gdb/devel/gdb-6.8-inlining-addon.patch?view=co Thanks for the link. Some of these I've already got fixes for. For instance, the changes in breakpoint.c about returning from a function to an inlined frame; I fixed it somewhere else, but we did discover that problem. Others, particularly the testsuite changes, I don't understand. I'd need to see a compiler that failed to work out why the changes were needed. So if you still need patches after the latest version of the patch is checked in, please let me know and I'll reproduce the failures. current_pc_is_notcurrent is interesting. Do I have the scenario right? * function() calls inlined() calls other() * finish from other() * show the end of inlined() instead of the next line of function() I can't figure out if we should do this or not. It does seem useful. But that's not where we are; we're showing the previous call site instead of the next instruction. I think we should consider it as a general change for finish instead of specific to inlining. The comments in your patch suggested that too. I merged the read_type_die fix, thanks. -- Daniel Jacobowitz CodeSourcery