Re: [rfa/Ada] Restructure array bounds routines to remove builtin types

Ulrich Weigand
2009-06-29T17:29:03Z

Joel Brobecker wrote:

> Looks OK to me, and verified also against AdaCore's testsuite
> on x86-linux (DWARF and stabs).

Thanks for the quick review! I've committed the patch now.

> Just one tiny request:
>
> > -struct type *
> > -ada_index_type (struct type *type, int n)
> > +static struct type *
> > +ada_index_type (struct type *type, int n, const char *name)
>
> Would you mind documenting what this new NAME parameter is supposed
> to be?

Here's what I committed on top of the original patch:

ChangeLog:

* ada-lang.c (ada_index_type): Update comment.

Index: gdb/ada-lang.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-lang.c,v
retrieving revision 1.217
diff -u -r1.217 ada-lang.c
--- gdb/ada-lang.c 29 Jun 2009 17:22:10 -0000 1.217
+++ gdb/ada-lang.c 29 Jun 2009 17:24:55 -0000
@@ -2408,7 +2408,10 @@
}

/* The type of nth index in arrays of given type (n numbering from 1).
- Does not examine memory. */
+ Does not examine memory. Throws an error if N is invalid or TYPE
+ is not an array type. NAME is the name of the Ada attribute being
+ evaluated ('range, 'first, 'last, or 'length); it is used in building
+ the error message. */

static struct type *
ada_index_type (struct type *type, int n, const char *name)

Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com