Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.

Tom Tromey
2009-05-28T01:16:38Z

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

I like this patch quite a bit.

It has a number of minor formatting problems, mostly missing spaces
before open parens.

Paul> + caddr_t retbuf = mmap (0, map_length, PROT_READ, MAP_PRIVATE,
Paul> + fileno ((FILE *)abfd->iostream),
Paul> + pg_offset);

I don't know for sure, but I assume that it is not valid in general to
cast iostream like this.

Tom