Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.

Tom Tromey
2009-05-30T22:36:23Z

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Tom> It has a number of minor formatting problems, mostly missing spaces
Tom> before open parens.

Paul> Sorry, these get me every time :-(

Yeah. Whatever happened to running gdb_indent.sh?

Paul> I would have used bfd_get_file_window(), but it's only compiled in
Paul> when --use-mmap was given to bfd/configure.
Paul> Is there a way to turn that on for GDB?

Paul> Is it ok to do this in gdb/dwarf2read.c:
Paul> if (info->size > 4 * pagesize && (sectp->flags & SEC_RELOC) == 0
Paul> && (abfd->flags & BFD_IN_MEMORY) == 0)

I don't know the answer to either of these.
If nobody here knows, I suggest asking on the binutils list.
If they aren't ok, maybe we could add a new BFD function for this.

Tom