From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5672 invoked by alias); 24 Jun 2009 19:28:01 -0000 Received: (qmail 5629 invoked by uid 22791); 24 Jun 2009 19:28:00 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Jun 2009 19:27:55 +0000 Received: (qmail 23210 invoked from network); 24 Jun 2009 19:27:53 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jun 2009 19:27:53 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] gdbserver: Add support for Z0/Z1 packets Date: Wed, 24 Jun 2009 19:28:00 -0000 User-Agent: KMail/1.9.10 Cc: Aleksandar Ristovski , Doug Evans References: <200906242011.16184.pedro@codesourcery.com> <4A427C5B.8080205@qnx.com> In-Reply-To: <4A427C5B.8080205@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906242028.52368.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00661.txt.bz2 On Wednesday 24 June 2009 20:19:55, Aleksandar Ristovski wrote: > Your patch: Wasn't it more desireable to distinguish between > (1) -unsupported and > (-1)-error? > > i.e. in "default", shouldn't it be "res=-1" so that it makes > it clear that gdb passed invalid argument? Z0, Z1, Z2, etc. are different packets, the "type" is not an argument to a Z packet. If we ever came up with a Z8 packet, a gdbserver not recognizing it should reply "unsupported", not error. > > Testsuite: I do run it but I admit sometimes not due to > issues my system is giving me lately; I have to run tests > "manually" i.e. one by one (I'll have to take some time to > figure out why is the test run, after some time, just > starting to ERROR, unable to properly spawn new gdb instance). Okay, but there's always test with local gdbserver on linux or Windows otherwise. It's really easy: http://sourceware.org/gdb/wiki/Native_gdbserver_testing -- Pedro Alves