From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18416 invoked by alias); 23 Jun 2009 18:21:55 -0000 Received: (qmail 18405 invoked by uid 22791); 23 Jun 2009 18:21:54 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Jun 2009 18:21:44 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n5NILgNF012770 for ; Tue, 23 Jun 2009 14:21:42 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5NILgqo002383 for ; Tue, 23 Jun 2009 14:21:42 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5NILe8Q005792; Tue, 23 Jun 2009 14:21:41 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n5NILeH2032197; Tue, 23 Jun 2009 20:21:40 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n5NILdKA032196; Tue, 23 Jun 2009 20:21:39 +0200 Date: Tue, 23 Jun 2009 18:21:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: Paul Pluzhnikov , gdb-patches@sources.redhat.com Subject: Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.] Message-ID: <20090623182139.GA30969@host0.dyn.jankratochvil.net> References: <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> <8ac60eac0906101842y2d2fc9fco331cb4336d9508d0@mail.gmail.com> <8ac60eac0906161342m67c30151lc7f685e0eb36e41f@mail.gmail.com> <8ac60eac0906161407s6498913cu5e50e930d599be77@mail.gmail.com> <20090623150322.GA7654@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00629.txt.bz2 On Tue, 23 Jun 2009 20:08:41 +0200, Tom Tromey wrote: > >>>>> "Jan" == Jan Kratochvil writes: > > Jan> while sure your patch is great it has a regression. Assuming a regression > Jan> reproducer needs to link GDB with -lmcheck (but did verify it). ^I ^not > This is ok. Checked-in. http://sourceware.org/ml/gdb-cvs/2009-06/msg00148.html > Jan> + Try to keep the freeing order compatible with free_objfile. */ > > It seems like it would be nice to have a single function here. IMO the whole `struct objfile' should replaced by a new one (instead of its in-place patching). Which will probably have other dependencies... Thanks, Jan