From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9560 invoked by alias); 23 Jun 2009 15:59:32 -0000 Received: (qmail 9548 invoked by uid 22791); 23 Jun 2009 15:59:31 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Jun 2009 15:59:20 +0000 Received: (qmail 13419 invoked from network); 23 Jun 2009 15:59:18 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Jun 2009 15:59:18 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] gdbserver: Add support for Z0/Z1 packets Date: Tue, 23 Jun 2009 15:59:00 -0000 User-Agent: KMail/1.9.10 Cc: Aleksandar Ristovski , Doug Evans References: <200906222346.54263.pedro@codesourcery.com> <4A40F226.4080909@qnx.com> In-Reply-To: <4A40F226.4080909@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906231700.12402.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00609.txt.bz2 On Tuesday 23 June 2009 16:17:58, Aleksandar Ristovski wrote: > Pedro Alves wrote: > > On Monday 22 June 2009 20:38:50, Aleksandar Ristovski wrote: > > > >>> Z0 and Z1 breakpoints also take a 'len' argument, just > >>> like Z2-Z4. You should also pass those down. > >>> > >>> But, Let's take a step back --- why not just rename the > >>> insert_watchpoint|remove_watchpoint functions to insert_point,remove_point, > >>> and relax the type checks in server.c: > >> But either way is fine with me - just let me know. > > > > I'd prefer the approach I suggested, and worry about splitting > > the breakpoints from watchpoints API if/when we actually need it. > > > > Ok, then that version is committed. Well, we had never seen "that" version, and you bypassed the "rename" suggestion... Would you care to explain why are watchpoints guarded on require_running and breakpoints aren't? It's not super obvious to me. > I attached what I committed. > > ChangeLog: > > * server.c (process_serial_event): Add support for Z0 and Z1 > packet. > * target.h: Comment for *_watchpoint to make it clear the > functions > can get types '0' and '1'. -- Pedro Alves