Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs.

Paul Pluzhnikov
2009-06-22T19:42:54Z

On Mon, Jun 22, 2009 at 12:28 PM, Ulrich Weigand<uweigand@de.ibm.com> wrote:

> In any case, I don't think your patch fixes the problem in the case
> where more than one objfile defines _ovly_debug_event:

Yes, I realized that soon after posting the patch as well :-(

> In fact, I don't really see an easy way to identify the originating
> objfile just from looking at the breakpoint.  Maybe we could set addr_string
> to some string that uniquely identifies the objfile when creating the
> breakpoint?  It isn't really used for a lot else for bp_overlay_event
> breakpoints (except for the maint info breakpoint output).

Perhaps a better alternative is to restore the overlay-bp-reset behavior to
"before 2009-05-12" commit: now that this change is in:

2009-06-16 Paul Pluzhnikov <ppluzhnikov@google.com>

* solib.c (symbol_add_stub): New FLAGS parameter.
...
(solib_add): Defer breakpoint_re_set until after all solibs.

the 2009-05-12 change (I believe -- I'd need to verify that) should no
longer make any difference.

Thanks,
--
Paul Pluzhnikov