From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9445 invoked by alias); 22 Jun 2009 03:18:44 -0000 Received: (qmail 9436 invoked by uid 22791); 22 Jun 2009 03:18:44 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 03:18:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 17EAC2BAB04; Sun, 21 Jun 2009 23:18:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id u0V21i3zprVk; Sun, 21 Jun 2009 23:18:36 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A8A5B2BAB02; Sun, 21 Jun 2009 23:18:35 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A3A7BF596C; Sun, 21 Jun 2009 20:18:32 -0700 (PDT) Date: Mon, 22 Jun 2009 03:18:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: Vladimir Prus , Chris Genly , gdb-patches@sources.redhat.com Subject: Re: gdb.texinfo patch for -var-list-children (2) Message-ID: <20090622031832.GA7766@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00557.txt.bz2 > > I suggest you use unified diffs for patches (cvs diff -u). The > > default "context" format is some historically-inflicted thing that > > is hard to read. > > I'm fine with both context and unified diffs. That's very kind of you to accept context diffs, but I do feel that most reviewers are more comfortable with unified diffs - so I suggest we keep asking for unified for future patches. I, for one, cannot read context diffs. I usually don't ask a resend, and convert the patch from one format to the next, but I like to ask that future patches be in unified format. -- Joel