From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22764 invoked by alias); 21 Jun 2009 01:27:01 -0000 Received: (qmail 22756 invoked by uid 22791); 21 Jun 2009 01:27:00 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_83,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 21 Jun 2009 01:26:55 +0000 Received: (qmail 9886 invoked from network); 21 Jun 2009 01:26:53 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Jun 2009 01:26:53 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] testsuite/gdb.base/fullname.exp fix Date: Sun, 21 Jun 2009 01:27:00 -0000 User-Agent: KMail/1.9.10 Cc: "Pierre Muller" References: <000501c9f12b$68c860e0$3a5922a0$@u-strasbg.fr> In-Reply-To: <000501c9f12b$68c860e0$3a5922a0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906210227.48175.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00544.txt.bz2 On Friday 19 June 2009 23:15:08, Pierre Muller wrote: > > fullname.exp currently fails compilation > of windows targets because it tries to recompile > the executable, while it is still running under GDB. Might this be a new failure? We have a few bfd_cache_close_all calls around to prevent this. Hmm, probably not. Anyone thinks we should do something to prevent this from happening? AFAICS, this particular case is something like: > gdb filefoo (gdb opens the exec_file does things, and the calls bfd_cache_close_all.) (gdb) b main << this reads file memory and reopens the bfd, nothing closes it. Maybe we could always call bfd_cache_close_all after executing a command... Dunno, maybe that's going too far? Probably will still be defeated by the new dwarf memory mapped files support if that ever is ported to Windows (I think Cygwin has now some magic to be able to remove open files? Maybe I'm dreaming.) On Friday 19 June 2009 23:15:08, Pierre Muller wrote: > 2009-06-19 Pierre Muller > > * fullname.exp: Exit gdb before recompile as some operating systems > lock the executable while it is running. > This is OK if it isn't a new failure, and no one has replies to the above questions, and if you move the "why" note from the changelong entry to the .exp file. The changelog header indicates "who" and "when". The changelog entry itself indicates "what". The "why" belongs in the code. -- Pedro Alves