From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28064 invoked by alias); 20 Jun 2009 16:01:44 -0000 Received: (qmail 27414 invoked by uid 22791); 20 Jun 2009 16:01:41 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_92,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Jun 2009 16:01:32 +0000 Received: (qmail 24288 invoked from network); 20 Jun 2009 16:01:28 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Jun 2009 16:01:28 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] gdbserver: Add qnx target Date: Sat, 20 Jun 2009 16:01:00 -0000 User-Agent: KMail/1.9.10 Cc: Aleksandar Ristovski References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906201702.20985.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00533.txt.bz2 On Wednesday 17 June 2009 19:50:02, Aleksandar Ristovski wrote: > configure script generated using autoconf-2.59-r7 Please make sure to use the version from: http://ftp.gnu.org/gnu/autoconf/ Note how your patch regenerated spurious changes. > ChangeLog: > * configure.ac (GDBSERVER_LIBS): Add $extra_srv_libs. > * configure: Regenerated using autoconfg 2.59-r7. > * Makefile.in (gdbreplay): Add $(GDBSERVER_EXTRA_LIBS) to > linking step > for both gdbserver and gdbreplay. Okay. Drop the "using autoconfg foo" bit once you get yourself the correct version. Adding an $srv_qnx variable, handled in configure.ac similarly to srv_mingw would also be acceptable, and could avoid duplication when you add support for more nto archs. We now have two ways to do the same thing... I don't have preferences for either --- we could also convert mingw targets to use GDBSERVER_LIBS. -- Pedro Alves