RE: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP

Pierre Muller
2009-06-16T23:54:38Z

This is perfectly OK for me,
could you check it in?
Otherwise I can check it in tomorrow.

Thanks for your replies

Pierre

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : Wednesday, June 17, 2009 1:46 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org; 'Eli Zaretskii'
> Objet : Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP
>
> On Wednesday 17 June 2009 00:20:06, Pierre Muller wrote:
> > +  /* On systems that load no shared libraries, like DJGPP target,
> > +     breakpoint_re_set is never called.
> > +     Call it now so that ordinary watchpoints get a chance to
> > +     become promoted to hardware watchpoints if the pushed target
> > +     supports hardware watchpoints.  */
> > +  breakpoint_re_set ();
> > +
>
> Much, much better, thanks. "systems that load no shared libraries"
> still isn't the right predicate, as I demonstrated with the
> linux static executable, and the breakpoint_re_set call due to
> adding the vsyscall page's symbols. I'd suggest expanding a bit
> more. Something like:
>
> /* If the user sets watchpoints before execution having started,
> then she gets software watchpoints, because GDB can't know which
> target will end up being pushed, or if it supports hardware
> watchpoints or not. breakpoint_re_set takes care of promoting
> watchpoints to hardware watchpoints if possible, however, if this
> new inferior doesn't load shared libraries or we don't pull in
> symbols from any other source on this target/arch,
> breakpoint_re_set is never called. Call it now so that software
> watchpoints get a chance to be promoted to hardware watchpoints
> if the now pushed target supports hardware watchpoints. */
> breakpoint_re_set ();
>
> (s/ordinary/software/. There's nothing unordinary about hardware
> watchpoints)
>
> --
> Pedro Alves