Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP

Pedro Alves
2009-06-16T22:59:16Z

On Tuesday 16 June 2009 23:37:38, Pierre Muller wrote:
>
> No one reacted to this second version of my patch...

My reaction was that the patch looked OK,
but please could you expand the comment some more to
explain a bit better why we need this:

+ /* Call breakpoint_re_set to update watchpoints types. */
+ breakpoint_re_set ();

This almost looks like:

+ /* Increment variable by one. */
+ i++;

;-)

breakpoint_re_set is very likely to be something we
will be wanting to split further, make smarter and/or
eliminate, so having its non-obvious uses nicely described
is a good thing, IMO.

> I still have other hardware watchpoint related problems
> that need to be discussed, but this one is really a small patch,
> no ?

--
Pedro Alves