Re: [patch] gdbserver: qXfer multiprocess

[Pedro Alves <pedro@codesourcery.com>]

On Wednesday 17 June 2009 01:56:06, Aleksandar Ristovski wrote:
> Pedro Alves wrote:
> > On Tuesday 16 June 2009 21:10:14, Aleksandar Ristovski wrote:
> > 
> >> This adds check for multiprocess before appending 
> >> 'multiprocess' to reply.
> > 
> > I can see that from the patch.  But, why?
> > 
> 
> If gdbserver doesn't have support for multiple processes, 
> how will it report lack of that feature to GDB?

By querying the target, how else?  Something like:

+      if (target_supports_multi_process ())
      strcat (own_buf, ";multiprocess+");

      if (target_supports_non_stop ())
	strcat (own_buf, ";QNonStop+");

(that function doesn't exist today, but it should).

> I have created gdbserver for nto to be able to use gdb for 
> nto/linux. One of things this server will not have (at least 
> for now) is multi process support. It will only handle one 
> process a time.

That is different from (like your patch was doing) reporting
multi_process support if GDB reports support as well, which is
still broken in your example.  (and now that you mention it,
in all gdbserver targets but linux).

-- 
Pedro Alves