From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27812 invoked by alias); 11 Jun 2009 20:40:14 -0000 Received: (qmail 27803 invoked by uid 22791); 11 Jun 2009 20:40:14 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Jun 2009 20:40:08 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n5BKe0gn016482; Thu, 11 Jun 2009 22:40:00 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n5BKdxrg027646; Thu, 11 Jun 2009 22:39:59 +0200 (CEST) Date: Thu, 11 Jun 2009 20:40:00 -0000 Message-Id: <200906112039.n5BKdxrg027646@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: aristovski@qnx.com CC: gdb-patches@sources.redhat.com In-reply-to: (message from Aleksandar Ristovski on Thu, 11 Jun 2009 15:15:56 -0400) Subject: Re: [patch] nto target: Code cleanup References: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00323.txt.bz2 > From: Aleksandar Ristovski > Date: Thu, 11 Jun 2009 15:15:56 -0400 > > Hello, > > This patch removes i386_nto_target as unnecessary indirection. > > Thanks, > > -- > Aleksandar Ristovski > QNX Software Systems > > ChangeLog: > > * i386-nto-tdep.c (i386_nto_target): Remove definition. > (init_i386nto_ops): Use macros to set fields to global > current_nto_target directly. > (i386nto_init_abi): Remove unused nto_set_target call. > * nto-tdep.h (nto_set_target): Remove unused declaration. > * nto-tdep.c (nto_set_target): Remove unused function. Not sure this is a step in the right direction. This being in a -tdep.c file pretty much makes it impossible to build a multi-arch GDB that supports multiple NTO targets.