From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64430-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21507 invoked by alias); 11 Jun 2009 19:59:06 -0000
Received: (qmail 21499 invoked by uid 22791); 11 Jun 2009 19:59:05 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Jun 2009 19:58:59 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n5BJwSmv023954; 	Thu, 11 Jun 2009 21:58:28 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n5BJwSua020394; 	Thu, 11 Jun 2009 21:58:28 +0200 (CEST)
Date: Thu, 11 Jun 2009 19:59:00 -0000
Message-Id: <200906111958.n5BJwSua020394@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: aristovski@qnx.com
CC: gdb-patches@sources.redhat.com, brobecker@adacore.com
In-reply-to: <4A312369.900@qnx.com> (message from Aleksandar Ristovski on Thu, 	11 Jun 2009 11:31:53 -0400)
Subject: Re: [patch] i386-nto-tdep.c: Add support for xmm registers.
References: <gvk3os$8fg$1@ger.gmane.org> <20090611150929.GF25703@adacore.com> <4A312369.900@qnx.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00317.txt.bz2

> From: Aleksandar Ristovski <aristovski@qnx.com>
> Date:  Thu, 11 Jun 2009 11:31:53 -0400
> 
> Thank you for reviewing the patch!
> 
> Joel Brobecker wrote:
> >> Add support for XMM registers.
> >> * i386-nto-tdep.c (i386_nto_target): Remove definition.
> >> (i386nto_regset_id): Add case for SSE register set.
> >> (i386nto_register_area): Correctly calculate offsets and sizes for all 
> >> supported registers.
> >> (I386_NTO_SIGCONTEXT_OFFSET): Remove macro definition.
> >> (i386nto_sigcontext_addr): Use better method of retrieving sigcontext 
> >> pointer.
> >> (init_i386nto_ops): Remove i386_nto_target.
> >> (i386nto_init_abi): Remove nto_svr4_so_ops indirection. Properly setup 
> >> tdep params sc_reg_offset and sc_num_regs. Remove nto_svr4_so_ops and 
> >> make changes accordingly.
> > 
> > I won't pretend I understand everything you do in this patch, but
> > the pieces that are related to registers and sigcontext seem to be
> > sensible.
> > 
> > However, I found a few hunks which I think are not related to XMM
> > register support, but rather to shared library support...
> 
> Attached is "clean" XMM support patch.
> 
> Thanks,
> 
> -- 
> Aleksandar Ristovski
> QNX Software Systems
> 
> ChangeLog:
> 
> 
> 	Add support for XMM registers.
> 	* i386-nto-tdep.c (i386nto_regset_id): Add case for SSE 
> register set.
> 	(i386nto_register_area): Correctly calculate offsets and 
> sizes for
> 	all supported registers.

Looks reasonable to me (assuming the wrapped lines in the ChangeLog
are caused by your broken mail client).