Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [02/15] Python interpreter callback functions
Date: Wed, 10 Jun 2009 15:49:00 -0000	[thread overview]
Message-ID: <200906101548.n5AFmuG9013008@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <m3eittl250.fsf@fleche.redhat.com> from "Tom Tromey" at Jun 09, 2009 11:59:07 AM

Tom Tromey wrote:

> I think this is ok as a default, but ideally the various Python
> methods would take an optional architecture argument.  That would mean
> having some Python representation of the architecture.

Right. 

> I think any place that acquires the GIL should probably also set the
> architecture.  I noticed that gdbpy_new_objfile was not touched in
> your patch; there may be other places as well.  Perhaps all this work
> could be done by a single convenience function, to make it harder to
> forget in the future.

Right, I overlooked gdbpy_new_objfile.  I'll fix that.  I can also
merge acquiring/releasing the GIL into make_cleanup_python_env ..

> If we had some notion of the "host architecture", then stuff like
> builtin_type_pyint could just use that instead.  Those defines really
> represent types on the host.

Note that even with my patch set applied, there are currently still 
some limitations on mixing and matching architectures.  For example,
you still cannot pass a value of arch A as argument to an inferior
function call of arch B.  These restrictions could presumably be
lifted over time, but for now, you'd have to deal with them if Python
values were of a different arch from the target ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2009-06-10 15:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 15:15 Ulrich Weigand
2009-06-09 17:59 ` Tom Tromey
2009-06-10 15:49   ` Ulrich Weigand [this message]
2009-06-22 20:59     ` Ulrich Weigand
2009-06-23 20:45       ` Tom Tromey
2009-07-02 17:06         ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906101548.n5AFmuG9013008@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox