Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Move the multi-forks support to the generic multi-inferiors support.
Date: Mon, 08 Jun 2009 23:16:00 -0000	[thread overview]
Message-ID: <200906090017.01168.pedro@codesourcery.com> (raw)
In-Reply-To: <m3skiamjxj.fsf@fleche.redhat.com>

On Monday 08 June 2009 23:37:12, Tom Tromey wrote:

> Pedro> (I was a bit surprised to (re-)find that MI doesn't use
> Pedro> print_inferior)
> 
> Naughty.  Though at a quick glance I didn't see where MI does any
> printing of the inferiors...?

It's in the -list-thread-groups command (mi_cmd_list_thread_groups/print_one_inferior).

> In this case I think the patch is ok anyway -- an error in "info
> threads" does not, IMO, imply that we should propagate the mistake to
> other commands.  Let me know what you think of this, I won't install
> the patch if you feel differently.

No, I agree with you.

My only concern is that the PID column may end up being
the wrong name for the target-id, due to targets that don't have a real
notion of PID.  I was planning of making that column's value print
something like target_pid_to_str (pid_to_ptid (PID)), just like the
corresponding column in info threads.  I was hoping that when
we'd get to name the columns in "info threads" we'd come up with
a nice name for it.  :-)

-- 
Pedro Alves


  reply	other threads:[~2009-06-08 23:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-30 23:13 Pedro Alves
2009-05-31 20:46 ` Tom Tromey
2009-05-31 22:07   ` Pedro Alves
2009-05-31 22:23     ` Doug Evans
2009-06-01 15:58     ` Tom Tromey
2009-06-06  0:09       ` Tom Tromey
2009-06-06 16:06         ` Pedro Alves
2009-06-08  1:34           ` Marc Khouzam
2009-06-08 22:43             ` Tom Tromey
2009-06-08 23:22               ` Pedro Alves
2009-06-08 22:39           ` Tom Tromey
2009-06-08 23:16             ` Pedro Alves [this message]
2009-06-10 22:09               ` Tom Tromey
2009-06-10 22:13                 ` Pedro Alves
2009-06-08 12:58 ` Pedro Alves
2009-06-11 19:32 ` Michael Snyder
2009-07-01 18:27   ` Pedro Alves
2009-07-01 19:16     ` Eli Zaretskii
2009-07-02 14:32       ` Pedro Alves
2009-07-02 19:00         ` Eli Zaretskii
2009-07-02 21:59           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906090017.01168.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox