Re: varobj bug?

Pedro Alves
2009-06-10T23:41:04Z

On Tuesday 09 June 2009 22:09:14, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> [ Just stumbled on this while reading this code. ]
> Pedro> Isn't the patch below a bug fix? FI possibly points at
> Pedro> the frame returned by:
> Pedro> fi = find_frame_addr_in_frame_chain (frame);
> Pedro> not the originally selected frame.
>
> I agree with your analysis.

Thanks. I tested and checked in the fixlet with this
changelog entry:

2009-06-11 Pedro Alves <pedro@codesourcery.com>

* varobj.c (varobj_create): Properly restore the selected frame.

> Pedro> Maybe this code should be using make_cleanup_restore_current_thread?
>
> This also sounds reasonable.

Ok, I'll see about cooking something up.

--
Pedro Alves