From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: uweigand@de.ibm.com (Ulrich Weigand)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Remove current_gdbarch register handling from symbol readers
Date: Thu, 04 Jun 2009 12:36:00 -0000 [thread overview]
Message-ID: <200906041235.n54CZxke005634@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200905201503.n4KF3ofO011061@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at May 20, 2009 05:03:50 PM
> this patch removes most of the remaining instances of current_gdbarch
> from the symbol readers. These are all related to handling register
> numbers. The problem is that during symbol reading, we may not
> actually know the GDB register numbers for the target -- those may
> change once we actually connect to a target which may provide its
> own target description.
>
> What the patch does is to delay register renaming by storing the
> original number from the debug info into SYMBOL_VALUE, and perform
> the conversion to a GDB register number only when debug info is
> actually used -- at which time we must have a frame context in
> order to evaluate "register" symbols, so we can use the correct
> architecture.
>
> This is implemented by extending the SYMBOL_OPS field, which is
> currently only used for LOC_COMPUTED types, to also provide
> callback routine for LOC_REGISTER (and LOC_REGPARM_ADDR) types.
> All symbol readers using those types are adapted to provide
> an appropriate implementation of the callback.
I've now checked in this patch as well.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2009-06-04 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 15:04 Ulrich Weigand
2009-05-20 17:42 ` Eli Zaretskii
2009-05-21 0:52 ` Ulrich Weigand
2009-05-21 3:27 ` Eli Zaretskii
2009-05-25 13:15 ` Ulrich Weigand
2009-05-25 20:59 ` Eli Zaretskii
2009-05-26 19:01 ` Ulrich Weigand
2009-06-04 12:36 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906041235.n54CZxke005634@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox