From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64166-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28458 invoked by alias); 3 Jun 2009 22:10:38 -0000
Received: (qmail 28448 invoked by uid 22791); 3 Jun 2009 22:10:37 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Jun 2009 22:10:28 +0000
Received: (qmail 2546 invoked from network); 3 Jun 2009 22:10:26 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 3 Jun 2009 22:10:26 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] Error reporting during insert_breakpoints
Date: Wed, 03 Jun 2009 22:10:00 -0000
User-Agent: KMail/1.9.10
Cc: Michael Snyder <msnyder@vmware.com>
References: <4A26E026.2000705@vmware.com> <200906032246.44508.pedro@codesourcery.com>
In-Reply-To: <200906032246.44508.pedro@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200906032311.08737.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00053.txt.bz2

On Wednesday 03 June 2009 22:46:44, Pedro Alves wrote:
> > @@ -1223,10 +1223,10 @@ Note: automatically using hardware break
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 {
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fprintf_unfiltered (tmp_error_strea=
m,=20
> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 "Cannot insert breakpoint %d.\n",=20
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 "Cannot insert breakpoint %d",=20
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 bpt->owner->number);
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fprintf_filtered (tmp_error_stream,=
=20
> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "=
Error accessing memory address ");
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "=
 at memory address ");
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fputs_filtered (paddress (bpt->addr=
ess), tmp_error_stream);
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fprintf_filtered (tmp_error_stream,=
 ": %s.\n",
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 safe_strerror (val));
>=20
> I'm not objecting to the change, but, honestly, I don't see where
> the assumption was, or where it is being removed?

Oh, silly me.  It's the s/accessing/at/.  Ignore me there.  BTW, since
you're touching this, how about merging all those fprintf calls
into a single call, and wrapping the user visible string in _() for
translation?

--=20
Pedro Alves