From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9896 invoked by alias); 3 Jun 2009 17:49:13 -0000 Received: (qmail 9886 invoked by uid 22791); 3 Jun 2009 17:49:13 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Jun 2009 17:49:07 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.14.3/8.13.8) with ESMTP id n53Hn5ME026106 for ; Wed, 3 Jun 2009 17:49:05 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n53Hn4mN2609178 for ; Wed, 3 Jun 2009 19:49:04 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n53Hn4AS004399 for ; Wed, 3 Jun 2009 19:49:04 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n53Hn3xi004394; Wed, 3 Jun 2009 19:49:03 +0200 Message-Id: <200906031749.n53Hn3xi004394@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 03 Jun 2009 19:49:03 +0200 Subject: Re: [rfc] Eliminate duplicated logic with decimal operations To: bauerman@br.ibm.com (Thiago Jung Bauermann) Date: Wed, 03 Jun 2009 17:49:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1244039252.13165.4.camel@hactar> from "Thiago Jung Bauermann" at Jun 03, 2009 11:27:31 AM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00042.txt.bz2 Hi Thiago, > Em Qui, 2009-05-14 às 13:32 +0200, Ulrich Weigand escreveu: > > The patch below removes steps 2 and 3 and only keeps the first > > conversion to decNumber. This applies to both decimal_binop and > > decimal_compare. > > > > Thiago, any thoughts on this? Do you agree that those conversions > > are unnecessary? > > Thanks for this improvement! I agree with you, those are silly > conversions. Thanks for your review. I've checked this patch in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com