From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Aleksandar Ristovski <aristovski@qnx.com>
Subject: Re: ptid from core section
Date: Wed, 03 Jun 2009 14:41:00 -0000 [thread overview]
Message-ID: <200906031541.49256.pedro@codesourcery.com> (raw)
In-Reply-To: <4A23F9FF.8040708@qnx.com>
On Monday 01 June 2009 16:55:43, Aleksandar Ristovski wrote:
> In corelow.c we have several architecture specific lines for
> determining ptid from core section. The same for getting
> section name given inferior_ptid.
>
> This patch moves architecture specific parts into two new
> functions: gdbarch_ptid_from_core_section and
> gdbarch_core_section_name_from_ptid.
>
> They replace Pedro's gdbarch_core_reg_section_encodes_pid
> since predicate is now redundant.
>
> I haven't added diffs for generated gdbarch.h/c, I would
> like to get your thoughts about this first.
As we talked about on IRC the other day, a better solution
could require a redesign and normalization of how bfd exposes these
thread/lwp/process ids. In principle, this change is fine
with me, but it seems you forgot to attach the patch. :-)
It would be nice if you included the nto bits in the
patch, so we can see how this helps in your case, so
that people can check upfront if this change is
sufficient and good.
--
Pedro Alves
next prev parent reply other threads:[~2009-06-03 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 15:56 Aleksandar Ristovski
2009-06-03 14:41 ` Pedro Alves [this message]
2009-06-03 16:59 ` Aleksandar Ristovski
2009-06-03 18:41 ` Pedro Alves
2009-06-04 18:32 ` Aleksandar Ristovski
2009-06-05 13:43 ` Pedro Alves
2009-06-05 14:04 ` Aleksandar Ristovski
2009-06-05 14:39 ` Pedro Alves
2009-06-05 14:53 ` Aleksandar Ristovski
2009-06-05 16:26 ` Pedro Alves
2009-06-05 17:54 ` Aleksandar Ristovski
2009-06-05 19:00 ` Pedro Alves
2009-06-05 19:03 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906031541.49256.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox