Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Doug Evans <dje@google.com>
Subject: Re: [RFA]: handle_extended_wait: Call linux_resume_one_lwp instead of ptrace
Date: Sun, 24 May 2009 17:00:00 -0000	[thread overview]
Message-ID: <200905241800.42885.pedro@codesourcery.com> (raw)
In-Reply-To: <20090524031422.C486F846C2@localhost>

On Sunday 24 May 2009 04:14:22, Doug Evans wrote:

> There are some things that linux_resume_one_lwp does that either
> all callers of ptrace (PTRACE_CONT) should do (check errno)
> or would be nice to do (print a debugging message).
> I was thinking of splitting linux_resume_one_lwp into two,
> but since the newly created thread is, well, new the rest of
> linux_resume_one_lwp is a nop; so it seems reasonable to just call
> linux_resume_one_lwp for the new thread.
> It's also nice to have all calls to ptrace (PTRACE_CONT)
> routed through one function.

Agreed.  It doesn't look like there are extra syscalls and
it's all O(1) in that fast path.

> 
> Ok to check in?
> [tested on amd64 w/ --target_board=native-gdbserver, no regressions]
> 
> 2009-05-23  Doug Evans  <dje@google.com>
> 
> 	* linux-low.c (handle_extended_wait): Use linux_resume_one_lwp
> 	to resume the newly created thread, don't call ptrace (PTRACE_CONT)
> 	directly.

Ok.

-- 
Pedro Alves


      reply	other threads:[~2009-05-24 17:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24  3:14 Doug Evans
2009-05-24 17:00 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905241800.42885.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox