From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22142 invoked by alias); 23 May 2009 11:12:39 -0000 Received: (qmail 22132 invoked by uid 22791); 23 May 2009 11:12:38 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 May 2009 11:12:35 +0000 Received: (qmail 18451 invoked from network); 23 May 2009 11:12:32 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 May 2009 11:12:32 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [Prec/RFA] Remove macros for record size in i386-linux-tdep.c Date: Sat, 23 May 2009 11:12:00 -0000 User-Agent: KMail/1.9.10 Cc: Hui Zhu References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200905231212.37685.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00506.txt.bz2 On Saturday 23 May 2009 05:00:22, Hui Zhu wrote: > 2009-05-23 =A0Hui Zhu =A0 >=20 > =A0=A0=A0=A0=A0=A0=A0=A0* i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*, > =A0=A0=A0=A0=A0=A0=A0=A0I386_LINUX_RECORD_IOCTL_*, > =A0=A0=A0=A0=A0=A0=A0=A0I386_LINUX_RECORD_FCNTL_*) Removed. > =A0=A0=A0=A0=A0=A0=A0=A0(i386_linux_init_abi): Change size of record from= macros to > =A0=A0=A0=A0=A0=A0=A0=A0numbers. Okay. > =A0=A0=A0=A0=A0=A0=A0=A0* i386-linux-tdep.c (i386_linux_init_abi): Change > =A0=A0=A0=A0=A0=A0=A0=A0i386_linux_record_tdep.size_char from 8 to 1. You didn't mention this, so I take it it was going to be a separate patch. Why do you need size_char at all? size of char is always 1 by definition. Does the kernel define this as variable somewhere also? --=20 Pedro Alves