From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2715 invoked by alias); 22 May 2009 17:10:22 -0000 Received: (qmail 2704 invoked by uid 22791); 22 May 2009 17:10:20 -0000 X-Spam-Check-By: sourceware.org Received: from pool-173-48-46-134.bstnma.fios.verizon.net (HELO cgf.cx) (173.48.46.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 May 2009 17:10:16 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id BA8DE13C023; Fri, 22 May 2009 13:10:04 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id BE46A6E7863; Fri, 22 May 2009 13:10:05 -0400 (EDT) Date: Fri, 22 May 2009 17:10:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Joel Brobecker , Pierre Muller Subject: Re: [RFA/Windows] Remove ADD_SHARED_SYMBOL_FILES macro Message-ID: <20090522171005.GC15288@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Joel Brobecker , Pierre Muller References: <003d01c9d4e2$987399a0$c95acce0$@u-strasbg.fr> <20090522153042.GB23016@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090522153042.GB23016@adacore.com> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00496.txt.bz2 Thanks for relabelling the subject so that I'd notice it. On Fri, May 22, 2009 at 08:30:42AM -0700, Joel Brobecker wrote: >> 2009-05-15 Pierre Muller >> >> * symfile.c (add_shared_symbol_files_command): Remove >> prototype and function. >> (_initialize _symfile): Move "add-shared-symbol-files" >> command and "assf" alias. > >This part is fine. > >> * windows-nat.c (_initialize_windows_nat): to here. > >This part, however, is unnecessary, I think. There is already a command >called dll-symbols that calls the very same function (dll_symbol_command). >My suggestion would be to delete the add-shared-symbols-files entirely, >or to make it a deprecated alias to dll-symbols. > >Chris, what do you think? I don't know enough about how other people use this command. I use dll-symbols all of the time (for one specific dll which shall go unamed). I don't know if people are using other commands instead so I don't think it can be deleted. Making it an alias makes sense, though. With that change, I'm fine with checking this in. cgf