From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31600 invoked by alias); 22 May 2009 04:13:57 -0000 Received: (qmail 31591 invoked by uid 22791); 22 May 2009 04:13:56 -0000 X-Spam-Check-By: sourceware.org Received: from pool-173-48-46-134.bstnma.fios.verizon.net (HELO cgf.cx) (173.48.46.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 May 2009 04:13:51 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 6F5E613C023; Fri, 22 May 2009 00:13:40 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id 6DFE242AB7E; Fri, 22 May 2009 00:13:41 -0400 (EDT) Date: Fri, 22 May 2009 04:13:00 -0000 From: Christopher Faylor To: gdb-patches ml , Hui Zhu Subject: Re: [Prec/RFA] fix build error of prec in cygwin Message-ID: <20090522041341.GA13509@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches ml , Hui Zhu References: <20090518153510.GA23052@ednor.casa.cgf.cx> <20090521152621.GA27524@ednor.casa.cgf.cx> <20090521173804.GA27866@ednor.casa.cgf.cx> <20090522004623.GI28993@ednor.casa.cgf.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00479.txt.bz2 On Fri, May 22, 2009 at 10:12:01AM +0800, Hui Zhu wrote: >On Fri, May 22, 2009 at 08:46, Christopher Faylor > wrote: >> On Fri, May 22, 2009 at 07:14:48AM +0800, Hui Zhu wrote: >>>On Fri, May 22, 2009 at 01:38, Christopher Faylor ?wrote: >>>> On Fri, May 22, 2009 at 12:43:07AM +0800, Hui Zhu wrote: >>>>>Thanks for you help me review my patch. ?Could you give me some help >>>>>with it? ?Actually, try something with cygwin still a very hard thing >>>>>for me. ?I just can use it in a notebook of other guy. ?And I had >>>>>return it. ?Maybe you can make a patch for this bug. ?That will be very >>>>>great for me. >>>> >>>>I don't see why this has anything to do with Cygwin. ??We're talking >>>>about general principles here. ?If you know C, which you obviously do, >>>>then I don't really understand why this needs a lot of explanation. >>>>Look at the places where you're using coercion with a format string and >>>>just use the right format specifier instead. >>> >>>Because the patch must be work OK with cygwin. ?Even if for the format. >>>I think you must have a lot of good idea with it. ?We need your help. >>>That is very great for me. ?Thanks a lot. >> >> No need to thank me yet. ?I'll be happy to review your change when you >> make the simple changes that I requested. ?You can hold off thanking me >> until then. > >About %u and sizeof, if without (int). It's OK with cygwin. But it >cannot work OK with amd64. >It will get: >../../src/gdb/linux-record.c: In function ?record_linux_system_call?: >../../src/gdb/linux-record.c:551: warning: format ?%u? expects type >?unsigned int?, but argument 4 has type ?long unsigned int? >Could you give me some help with it? "%zu" cgf