Re: [RFA] Fix printing frame arguments for COFF debug info

Eli Zaretskii
2009-05-21T03:22:59Z

> Date: Wed, 20 May 2009 14:32:00 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> > The first step towards solving this is to fix coffread.c, as in the
> > patch I suggest below. OK to commit it?
>
> > 2009-05-16 Eli Zaretskii <eliz@gnu.org>
> >
> > * coffread.c (process_coff_symbol): Set the symbol's language to
> > the language of current_subfile.
>
> That seems like a sensible change, and it is something we also do
> in the stabs reader, so I'd say this is OK.

Thanks.

> > Even if this patch is accepted, I'm not sure that's all we need to do.
> > At least minsyms.c:prim_record_minimal_symbol_and_info also sets the
> > symbol's language to language_auto. Should we make sure neither
> > common_val_print nor val_print ever get language_auto as the language?
> > That is, should we fall back to current_language in that case?
>
> I see that this is addressed in one of your followup messages

Not really, no. The followup messages deal with a different problem.
This issue, i.e. whether common_val_print and/or val_print should be
defensive about getting language_auto, still remains. I'd like to
hear your opinion about that.