From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25372 invoked by alias); 20 May 2009 23:07:30 -0000 Received: (qmail 25294 invoked by uid 22791); 20 May 2009 23:07:29 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 May 2009 23:07:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 272572BABBE; Wed, 20 May 2009 19:07:17 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fot9GjxlzMhO; Wed, 20 May 2009 19:07:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 76FF22BAADE; Wed, 20 May 2009 19:07:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 59021F596C; Wed, 20 May 2009 23:32:00 +0200 (CEST) Date: Wed, 20 May 2009 23:07:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix printing frame arguments for COFF debug info Message-ID: <20090520213200.GE16152@adacore.com> References: <83d4a9q9e5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83d4a9q9e5.fsf@gnu.org> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00439.txt.bz2 > The first step towards solving this is to fix coffread.c, as in the > patch I suggest below. OK to commit it? > 2009-05-16 Eli Zaretskii > > * coffread.c (process_coff_symbol): Set the symbol's language to > the language of current_subfile. That seems like a sensible change, and it is something we also do in the stabs reader, so I'd say this is OK. > Even if this patch is accepted, I'm not sure that's all we need to do. > At least minsyms.c:prim_record_minimal_symbol_and_info also sets the > symbol's language to language_auto. Should we make sure neither > common_val_print nor val_print ever get language_auto as the language? > That is, should we fall back to current_language in that case? I see that this is addressed in one of your followup messages, so I'll send my take on it there. -- Joel