From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24703 invoked by alias); 15 May 2009 14:07:12 -0000 Received: (qmail 24693 invoked by uid 22791); 15 May 2009 14:07:11 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 May 2009 14:07:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8BC472BAAF1; Fri, 15 May 2009 10:07:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id X5oyTuTa4atB; Fri, 15 May 2009 10:07:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5D8592BAAE5; Fri, 15 May 2009 10:07:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E69E9F5962; Fri, 15 May 2009 16:07:01 +0200 (CEST) Date: Fri, 15 May 2009 14:07:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Ada simplification: ada_coerce_to_simple_array_type Message-ID: <20090515140701.GK7292@adacore.com> References: <200905141135.n4EBZsqG001678@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200905141135.n4EBZsqG001678@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00322.txt.bz2 > * ada-lang.c (ada_coerce_to_simple_array_type): Reimplement to > avoid creating a dummy value. I like this change. On the one hand, it's a slight duplication, but this is a relatively standard idiom, so it's OK. When I'm done reconciling the sources with AdaCore's, it'll be easier for me to overhaul the ada-* sources. Thanks for this patch. -- Joel