From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 811 invoked by alias); 14 May 2009 14:00:49 -0000 Received: (qmail 787 invoked by uid 22791); 14 May 2009 14:00:44 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 May 2009 14:00:36 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.14.3/8.13.8) with ESMTP id n4EDxkJe592018 for ; Thu, 14 May 2009 13:59:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4EDxjaQ3666038 for ; Thu, 14 May 2009 15:59:46 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4EDxjGI017502 for ; Thu, 14 May 2009 15:59:45 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n4EDxiLA017473; Thu, 14 May 2009 15:59:44 +0200 Message-Id: <200905141359.n4EDxiLA017473@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 14 May 2009 15:59:44 +0200 Subject: Re: [RFA] Add comment describing the target_gdbarch global To: brobecker@adacore.com (Joel Brobecker) Date: Thu, 14 May 2009 14:00:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20090507145243.GB659@adacore.com> from "Joel Brobecker" at May 07, 2009 07:52:44 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00301.txt.bz2 Joel Brobecker wrote: > > > 2009-05-06 Joel Brobecker > > > > > > * gdbarch.h (target_gdbarch): Add comment documenting this global. > > > > This looks fine to me. > > Excellent! Thanks for double-checking. I committed the patch after > having fixed a couple of typos. Patch attached for reference, but > basically a "pre" -> "per", and a "to" -> "from". Oops, I didn't notice that you're changing gdbarch.h directly. This is a generated file; you should be changing gdbarch.sh instead and regnerate the header file ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com