From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28847 invoked by alias); 14 May 2009 09:06:29 -0000 Received: (qmail 28838 invoked by uid 22791); 14 May 2009 09:06:28 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 May 2009 09:06:23 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.14.3/8.13.8) with ESMTP id n4E96KQ5331880 for ; Thu, 14 May 2009 09:06:20 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4E96Jkp3682362 for ; Thu, 14 May 2009 11:06:19 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4E96I6M016449 for ; Thu, 14 May 2009 11:06:18 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n4E96HAE016418; Thu, 14 May 2009 11:06:17 +0200 Message-Id: <200905140906.n4E96HAE016418@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 14 May 2009 11:06:17 +0200 Subject: Re: [RFA-v3] Remove i386 low level debug register function from nm- header file. To: muller@ics.u-strasbg.fr (Pierre Muller) Date: Thu, 14 May 2009 09:06:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, pedro@codesourcery.com ('Pedro Alves'), eliz@gnu.org ('Eli Zaretskii') In-Reply-To: <001101c9d424$141a7840$3c4f68c0$@u-strasbg.fr> from "Pierre Muller" at May 14, 2009 01:39:36 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00289.txt.bz2 Pierre Muller wrote: > Remove all i386 debug register low level macros in config nm files. > (I386_DR_LOW_SET_ADDR, I386_DR_LOW_RESET_ADDR): Remove. > (I386_DR_LOW_GET_STATUS, I386_DR_LOW_SET_CONTROL): Remove. > (I386_USE_GENERIC_WATCHPOIINTS): Remove. > > * i386-nat.h: New file (adapted from config/i386/nm-i386.h). > (struct i386_dr_low_type): New type. > (i386_dr_low): New global variable. > * i386-nat.c (TARGET_HAS_DR_LEN_8): Update macro. > (i386_insert_aligned_watchpoint): Replace i386 dr low macros by > i386_dr_low struct variable fields. > (i386_remove_aligned_watchpoint): Likewise. > (i386_stopped_data_address): Likewise. > (i386_stopped_by_hwbp): Likewise. > (show_debug_regs_command_added): New static variable. > (add_show_debug_regs_command): New static function. > (i386_use_watchpoints): Call add_show_debug_regs_command if not > done. > (i386_set_debug_register_length): New function. > (_initialize_i386_nat): Delete. > > * amd64-linux-nat.c: Include "i386-nat.h". > (amd64_linux_dr_set_control): Change to static. > (amd64_linux_dr_get_status): Change to static. > (amd64_linux_dr_set_addr,amd64_linux_dr_reset_addr): Likewise. > (_initialize_amd64_linux_nat): Set i386_dr_low variable fields. > > * go32-nat.c: Include "i386-nat.h". > (go32_set_addr): Change to static. > (go32_set_dr7): Change to static. Change arg type to unisgned long. > (go32_get_dr6): Change to static. Change return type to unisnged > long. > (init_go32_ops): Set i386_dr_low variable fields. > * i386-linux-nat.c: Include "i386-nat.h". > (i386_linux_dr_set_control, i386_linux_dr_get_status): Change to > static. > (i386_linux_dr_set_addr, i386_linux_dr_reset_addr): Idem. > (_initialize_i386_linux_nat): Set i386_dr_low variable fields. > * i386bsd-nat.h: Declare functions used for > i386_dr_low fields in i386fbsd-nat.c. > * i386fbsd-nat.c: Include "i386-nat.h". > (_initialize_i386fbsd_nat): Set i386_dr_low variable fields. > * windows-nat.c: Include "i386-nat.h". > (cygwin_set_dr, cygwin_get_dr6, cygwin_set_dr7): Add prototypes. > Change to static. > (cygwin_get_dr6): Change return type to unisnged long. > (cygwin_set_dr7): Change arg type to unisgned long. > (init_windows_ops): Set i386_dr_low function fields. > > * amd64-windows-nat.c (_initialize_amd64_windows_nat): Call > i386_set_debug_register_length. > * i386-windows-nat.c (_initialize_i386_windows_nat): Likewise. > > * config/i386/nm-cygwin.h: Remove all I386_* macros. > * config/i386/nm-cygwin64.h: Likewise. > * config/i386/nm-fbsd.h: Likewise. > * config/i386/nm-linux.h: Likewise. > * config/i386/nm-i386.h: Remove completely. > * config/i386/nm-go32.h: Remove completely. > * config/i386/nm-linux64.h: Remove completely. > * config/i386/go32.mh (NAT_FILE): Remove entry. > * config/i386/linux64.h (NAT_FILE): Change to config/nm-linux.h. This is OK. Thanks for doing this cleanup work! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com