From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: eliz@gnu.org
Cc: muller@ics.u-strasbg.fr, gdb-patches@sourceware.org,
pedro@codesourcery.com
Subject: Re: [RFC-v2] Remove i386 low level debug register function from nm- header file.
Date: Wed, 13 May 2009 18:35:00 -0000 [thread overview]
Message-ID: <200905131835.n4DIZFif003840@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <833ab8swm2.fsf@gnu.org> from "Eli Zaretskii" at May 13, 2009 09:09:41 PM
Eli Zaretskii wrote:
> > When you build on a 32-bit system, this probably won't result in
> > an error, even though it's strictly speaking still invalid C ...
>
> What is invalid C?
Assigning a function with prototype
void func (unsigned long arg);
to a function pointer with prototype
void (*ptr) (unsigned arg);
(even on platforms where "unsigned long" is the same size as
"unsigned").
> > As far as I know, those values are in fact 32-bit, so I guess
> > "unsigned" (or preferably, "unsigned int") should be OK to use.
>
> I see no need to add "int" to "unsigned", FWIW.
My comment was just for consistency with the rest of the code base.
I though we were not using plain "unsigned" anywhere else. However,
after checking the code base, it seems there's already a number of
places that do so. I don't really mind then, so I withdraw the
suggestion to use "unsigned int".
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2009-05-13 18:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 14:54 [RFC] " Pierre Muller
2009-05-10 17:37 ` Eli Zaretskii
2009-05-12 13:02 ` Ulrich Weigand
2009-05-12 14:37 ` Pierre Muller
2009-05-12 15:00 ` Ulrich Weigand
2009-05-12 15:17 ` Eli Zaretskii
2009-05-12 15:45 ` Pierre Muller
2009-05-12 16:06 ` Ulrich Weigand
2009-05-12 16:19 ` Pedro Alves
2009-05-12 21:28 ` [RFC-v2] " Pierre Muller
2009-05-13 15:33 ` Ulrich Weigand
2009-05-13 18:09 ` Eli Zaretskii
2009-05-13 18:35 ` Ulrich Weigand [this message]
2009-05-13 18:25 ` Doug Evans
2009-05-13 18:38 ` Ulrich Weigand
2009-05-13 22:21 ` Pierre Muller
2009-05-13 23:16 ` Doug Evans
2009-05-13 23:39 ` [RFA-v3] " Pierre Muller
2009-05-14 9:06 ` Ulrich Weigand
2009-05-14 9:10 ` Joel Brobecker
2009-05-14 9:40 ` Pierre Muller
2009-05-14 15:32 ` Macros in config files Pierre Muller
2009-05-14 18:31 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905131835.n4DIZFif003840@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox