From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22417 invoked by alias); 11 May 2009 17:50:51 -0000 Received: (qmail 22408 invoked by uid 22791); 11 May 2009 17:50:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_43,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 May 2009 17:50:45 +0000 Received: (qmail 21398 invoked from network); 11 May 2009 17:50:43 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 May 2009 17:50:43 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFC] i386/amd64 biarch gdbserver Date: Mon, 11 May 2009 17:50:00 -0000 User-Agent: KMail/1.9.10 Cc: Doug Evans References: <20090509191225.404D984890@localhost> In-Reply-To: <20090509191225.404D984890@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905111850.46214.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00220.txt.bz2 On Saturday 09 May 2009 20:12:25, Doug Evans wrote: > This patch implements biarch i386/amd64 gdbserver. > I haven't done anything with xml target descriptions, but there > are no regressions so it seems like a good stopping place. Yeah, this came up on IRC, when I mentioned about gdbserver multi-process, and debugging 32-bit and 64-bit inferiors simultaneously. The x86 and amd64 register sets aren't compatible, and, we've got a single target_gdbarch to represent the connection, so this is a problem. But it's one we can solve on top of this. > This patch also fixes a bug where current amd64 gdbserver > doesn't handle xmm[8-15]. Testcase to follow later. > > Tested on > - i386-linux > - x86_64-linux with gcc -m64 > - x86_64-linux with gcc -m32 (and hacking site.exp to specify i386-linux) > using --target_board=native-gdbserver > [ref http://sourceware.org/gdb/wiki/Native_gdbserver_testing] > > Comments? This looks good to me, but, I don't know how far can I stretch in gdbserver approvals. Small nit, you've added an `assert' call, but I think you should use `fatal' instead -- there are no other references to `assert' in gdbserver whole. > +/* Return non-zero if the target is 64-bit. */ > + > +static void > +x86_arch_setup (void) Misplaced comment? -- Pedro Alves