From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9435 invoked by alias); 8 May 2009 15:30:20 -0000 Received: (qmail 9425 invoked by uid 22791); 8 May 2009 15:30:18 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 May 2009 15:30:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6CA2B2BAC18; Fri, 8 May 2009 11:30:10 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5Gc2p9gpEZWC; Fri, 8 May 2009 11:30:10 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 39E172BAB12; Fri, 8 May 2009 11:30:10 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id AC7BFF5900; Fri, 8 May 2009 08:30:06 -0700 (PDT) Date: Fri, 08 May 2009 15:30:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Remove unecessary checks for macros in target.h Message-ID: <20090508153006.GH659@adacore.com> References: <003301c9cfe3$e7547ed0$b5fd7c70$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003301c9cfe3$e7547ed0$b5fd7c70$@u-strasbg.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00178.txt.bz2 > 2009-05-08 Pierre Muller > > * src/gdb/target.h: Remove all tests for already defined > macros. All macros defined here should not be set in config > headers anymore. Looks good to me. Can you also remove the following comment that now becomes obsolete? /* If the *_hw_beakpoint functions have not been defined elsewhere use the definitions in the target vector. */ As a followup patch, I'd go one step further and rename the macros that do not follow the general naming scheme in that file. For instance: STOPPED_BY_WATCHPOINT -> target_stopped_by_watchpoint. > PS: STOPPED_BY_WATCHPOINT macro could probably also loose its unused > parameter... Would this later patch be also welcome? Sure. That could be taken care of as part of the renaming above. -- Joel