From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23352 invoked by alias); 7 May 2009 23:05:42 -0000 Received: (qmail 23339 invoked by uid 22791); 7 May 2009 23:05:39 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 May 2009 23:05:34 +0000 Received: (qmail 21755 invoked from network); 7 May 2009 23:05:33 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 May 2009 23:05:33 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Process record and replay checked in to main trunk Date: Thu, 07 May 2009 23:05:00 -0000 User-Agent: KMail/1.9.10 Cc: Michael Snyder , Pierre Muller , "'Hui Zhu'" References: <001201c9cf62$8e2761a0$aa7624e0$@u-strasbg.fr> <4A036401.6060906@vmware.com> In-Reply-To: <4A036401.6060906@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905080006.19166.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00166.txt.bz2 On Thursday 07 May 2009 23:43:13, Michael Snyder wrote: > Guessing it isn't implemented for 64 bit. I don't think that's the problem here. Cygwin is 32-bit, and has 32-bit ints. > ../../purecvs/gdb/linux-record.c:397: warning: unsigned int format, uint32_t > arg > ../../purecvs/gdb/linux-record.c:629: warning: int format, uint32_t arg (arg Better use casts, or use plongest/pulongest/hex_string where appropriate? > Perhaps we should have a --disable-process-record config option? > If only for a back-up plan? I think that would be more work than fixing this properly. :-) > ../../purecvs/gdb/linux-record.c:1636: error: `F_GETLK64' undeclared (first > use > in this function) There are a bunch of RECORD_* macros defined on top of linux-record.c to replace contants like these. E.g., RECORD_Q_GETFMT. Looks like this case was just missed. -- Pedro Alves