From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28387 invoked by alias); 7 May 2009 16:49:37 -0000 Received: (qmail 28364 invoked by uid 22791); 7 May 2009 16:49:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_93 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 May 2009 16:49:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 301512BACB8; Thu, 7 May 2009 12:49:28 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mQZ2Mhybas8J; Thu, 7 May 2009 12:49:28 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8F7F32BACF7; Thu, 7 May 2009 12:49:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 122F3F5900; Thu, 7 May 2009 09:48:53 -0700 (PDT) Date: Thu, 07 May 2009 16:49:00 -0000 From: Joel Brobecker To: Jon Beniston Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for the Lattice Mico32 (LM32) architecture Message-ID: <20090507164853.GD659@adacore.com> References: <266F97CB7CD14C6899877E7D69AA2030@bibi> <20090207041443.GG3676@adacore.com> <26720080D2924381A7049C33A9DEB225@bibi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26720080D2924381A7049C33A9DEB225@bibi> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00156.txt.bz2 Jon, > 2009-04-15 Jon Beniston > > * MAINTAINERS: Add lm32 target. > * Makefile.in: Add lm32 dependencies. > * NEWS: Indicate lm32 is a new target. > * configure.tgt: Add lm32 targets. > * lm32-tdep.c: New file. > > gdb/testsuite > 2009-04-15 Jon Beniston > > * gdb.asm/asm-source.exp: Add lm32 target. This looks good overall. I just had one tiny observation. Please also double-check with Eli that the NEWS update is OK. That being said, I'm afraid that you won't be able to commit this patch until the sim counterpart is approved. This is due to the two dependencies (one in configure.tgt, and one in lm32-tdep.c) that you have. Have you heard from the sim maintainers? > /* Return PC of first non prologue instruction, for the function at the > specified address. */ > > static CORE_ADDR > lm32_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc) > { > CORE_ADDR func_addr, func_end, limit_pc; > struct symtab_and_line sal; > struct lm32_frame_cache frame_info; > struct trad_frame_saved_reg saved_regs[SIM_LM32_NUM_REGS]; > > /* See if we can determine the end of the prologue via the symbol table. > If so, then return either PC, or the PC after the prologue, whichever > is greater. */ > if (find_pc_partial_function (pc, NULL, &func_addr, &func_end)) You don't need the func_end variable, here, as you can just pass NULL instead. -- Joel