From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21631 invoked by alias); 6 May 2009 16:03:52 -0000 Received: (qmail 21553 invoked by uid 22791); 6 May 2009 16:03:43 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 May 2009 16:02:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1980B2BAC55; Wed, 6 May 2009 12:02:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Gmj701hY6GLN; Wed, 6 May 2009 12:02:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D5D662BAB3F; Wed, 6 May 2009 12:02:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0B959F5900; Wed, 6 May 2009 09:02:50 -0700 (PDT) Date: Wed, 06 May 2009 16:03:00 -0000 From: Joel Brobecker To: muller@ics.u-strasbg.fr Cc: gdb-patches@sourceware.org Subject: [ARI] Add "bzero" (was: "Re: Build failure for x86_64-pc-mingw32 target") Message-ID: <20090506160250.GJ10734@adacore.com> References: <200904301028.29435.pedro@codesourcery.com> <200905061038.11004.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <200905061038.11004.pedro@codesourcery.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00116.txt.bz2 --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 271 Pierre, Would you mind adding bzero to the list of functions in the ARI that should not be used? I think this would be useful to have. The following patch should work, but I'm not sure how you test it, and i'm also not sure about the right category... Thanks! -- Joel --ZPt4rx8FFjLCG7dd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="bzero-ari.diff" Content-length: 664 Index: gdb_ari.sh =================================================================== RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v retrieving revision 1.89 diff -u -p -r1.89 gdb_ari.sh --- gdb_ari.sh 20 Apr 2009 15:55:23 -0000 1.89 +++ gdb_ari.sh 6 May 2009 16:00:22 -0000 @@ -1028,6 +1028,14 @@ Do not use xvasprintf(), instead use xst # More generic memory operations +BEGIN { doc["bzero"] = "\ +Do not use bzero(), instead use memset()" + category["bzero"] = ari_regression +} +/(^|[^_[:alnum:]])bzero[[:space:]]*\(/ { + fail("bzero") +} + BEGIN { doc["strdup"] = "\ Do not use strdup(), instead use xstrdup()"; category["strdup"] = ari_regression --ZPt4rx8FFjLCG7dd--