From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11855 invoked by alias); 30 Apr 2009 18:30:09 -0000 Received: (qmail 11838 invoked by uid 22791); 30 Apr 2009 18:30:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Apr 2009 18:30:03 +0000 Received: (qmail 14735 invoked from network); 30 Apr 2009 18:30:01 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Apr 2009 18:30:01 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH] Program Breakpoints Date: Thu, 30 Apr 2009 18:30:00 -0000 User-Agent: KMail/1.9.10 Cc: Ross Morley References: <49F9E84D.3000109@tensilica.com> In-Reply-To: <49F9E84D.3000109@tensilica.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904301930.13526.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00817.txt.bz2 Before looking at the code, I'd like to see the interaction of program breakpoints with decr_pc_after_break adjustment formalized. I did a quick skim and couldn't find it handled. E.g, if you were to implement support for this on x86 gdbserver, assuming int3 traps, it appears to me that the only option is for the target to always rewind the pc before reporting to GDB, and for GDB to never adjust it itself, even for regular breakpoint hits, otherwise, e.g., consecutive breakpoints will be mishandled. This also suggests that there has to be prior negotiation (qSupported) to enable the support. Has this been considered? (A small request: please include the -p switch in your `cvs diff' commands, or add it to .cvsrc. I use -Nurp myself.) -- Pedro Alves